Migrate org.eclipse.search.tests from JUnit 4 to JUnit 5 #3446
+125
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the org.eclipse.search.tests bundle from JUnit 4 to JUnit 5, including all test files and the necessary dependency updates. Changes: - Updated imports from org.junit.* to org.junit.jupiter.api.* - Replaced @Before/@after with @BeforeEach/@AfterEach annotations - Replaced Assert with Assertions for all assertion methods - Updated test annotations from @test (JUnit 4) to @test (JUnit 5) - Migrated JUnitSourceSetup from @rule to @RegisterExtension - Updated assertions to use JUnit 5 style (message parameter last) MANIFEST.MF updates: - Removed JUnit 4 dependency (org.junit;bundle-version="4.13.2") - Added org.hamcrest;bundle-version="3.0.0" for matcher support - Added JUnit 5 Import-Package entries: - org.junit.jupiter.api;version="[5.14.0,6.0.0)" - org.junit.jupiter.api.extension;version="[5.14.0,6.0.0)" - org.junit.jupiter.api.function;version="[5.14.0,6.0.0)" - org.junit.platform.suite.api;version="[1.14.0,2.0.0)" - org.opentest4j (required for Assumptions.assumeFalse() in PositionTrackerTest) Files migrated: - AllFileSearchTests.java - AnnotationManagerTest.java - FileCharSequenceTests.java - FileSearchTests.java - JUnitSourceSetup.java - LineAnnotationManagerTest.java - PositionTrackerTest.java - ResultUpdaterTest.java - SearchResultPageTest.java - SortingTest.java Note: The org.opentest4j import was critical to fix compilation - it provides TestAbortedException used by JUnit 5's Assumptions API (specifically assumeFalse() in PositionTrackerTest.java:85). Verification: - Compilation succeeds with 0 errors - Tests compile and run successfully 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
@HeikoKlare FYI, this was including a @rule migration from Claude AI, IIRC these changes were the one you found more valuable in the update work. I just wanted to point out that this is also possible with AI (and some manual work, as I ran out of Claude tokens in this period). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the org.eclipse.search.tests bundle from JUnit 4 to JUnit 5, including all test files and the necessary dependency updates.
Changes:
MANIFEST.MF updates:
Files migrated:
Note: The org.opentest4j import was critical to fix compilation - it provides TestAbortedException used by JUnit 5's Assumptions API (specifically assumeFalse() in PositionTrackerTest.java:85).
Verification:
🤖 Generated with Claude Code